Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix integration test #11378

Merged
merged 5 commits into from
Feb 14, 2025
Merged

fix integration test #11378

merged 5 commits into from
Feb 14, 2025

Conversation

alecsavvy
Copy link
Contributor

@alecsavvy alecsavvy commented Feb 14, 2025 •
edited
Loading

Description

  • removes the custom build code for relay as tsc handles things correctly again
  • changes discprov health check in docker so it marks healthy in ci
  • adds missing dep to relay which was making it fail --prod build

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Integration test passed here https://github.com/AudiusProject/audius-protocol/runs/37248609272

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 24c6a76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schottra
schottra approved these changes Feb 14, 2025
View reviewed changes
.circleci/config.yml Outdated
@@ -345,6 +345,7 @@ workflows:
.circleci/.* run-web-workflow true
.circleci/.* run-mobile-workflow true
.circleci/.* run-embed-workflow true
.circleci/.* run-integration-workflow true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what these lines do, but I'm surprised this wasn't already here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added it so it would run on this PR specifically, it's faster than running --prod on my machine lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll remove once it passes when i merge

@alecsavvy alecsavvy changed the title adjust timeouts for discprov fix integration test Feb 14, 2025
@alecsavvy alecsavvy self-assigned this Feb 14, 2025
@alecsavvy alecsavvy enabled auto-merge (squash) February 14, 2025 18:54
@alecsavvy alecsavvy disabled auto-merge February 14, 2025 19:15
@alecsavvy alecsavvy merged commit 0342ae5 into main Feb 14, 2025
4 of 6 checks passed
@alecsavvy alecsavvy deleted the as/fix-ci-tests branch February 14, 2025 19:15
audius-infra pushed a commit that referenced this pull request Feb 17, 2025
Audius Protocol v0.7.92
a39c652 
[7d310ef] [PAY-3850][PAY-3849] Add listen streak noti on web (#11379) Farid Salau
[03d7f9e] [PAY-3946] Fix multiple plays in same batch breaking listen streak (#11380) Reed
[4066498] [C-5782, C-5783] Add user comments endpoint and tan query hook (#11366) Kyle Shanks
[0342ae5] fix integration test (#11378) alecsavvy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schottra schottra schottra approved these changes

Assignees

@alecsavvy alecsavvy

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecsavvy @schottra