This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Fix build issues #181
Merged
Fix build issues #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
force-pushed
the
rj-fix-build-issues
branch
from
85bb094
to
e328ebe
Compare
sliptype
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Thanks for doing this! Bad assumption on my part that since I didn't need any environment changes to build the 0.66 version that CI wouldn't need changes either.
I agree that we should probably build all branches to make sure that they aren't breaking. I can make that change
We can probably do so without too much difficulty -- just rip the 'pilot' stage out of the fastlane for builds that aren't prefixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
XCode change to 13.x necessary for new RN version (0.66). Ruby upgrade needed as a result.
React native config change: lugg/react-native-config#609
We should figure out how we can suss out build issues like this prior to cutting release branches. It's a too late to find out that your build is going to fail.
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Build via release branch
https://app.circleci.com/pipelines/github/AudiusProject/audius-mobile-client/789/workflows/8670b623-8f15-4cdb-b038-34a3df6ab8dd
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.