This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Update react-scripts to 4.x.x to fix terser CI issues #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this change https://frontend-demo.audius.co/rj-terser-3 |
raymondjacobson
requested review from
jowlee,
sddioulde and
piazzatron
and removed request for
jowlee
raymondjacobson
changed the title
jowlee
approved these changes
May 21, 2021
sliptype
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Update terser * Upgrade and fix lints * Fix mocks
sliptype
pushed a commit
that referenced
this pull request
Feb 12, 2022
* Update terser * Upgrade and fix lints * Fix mocks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think per @piazzatron 's callout of this comment, updating react-scripts and the lot with the terser version change fixes our issues.
facebook/create-react-app#8320 (comment)
I've run this workflow thrice and it passed all builds each time (so 9 in total).
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
Upgrading the version here is always dangerous, so we should soak this on staging for as long as we can, etc.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.