Adding more chords types + refactor of "Flat Fifth" to "Flat Five" in all chord type cases #39
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| func testMajor7thFlatFive() { | ||
| let notes: [Int8] = [60, 64, 66, 71] | ||
| let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } ) |
There was a problem hiding this comment.
Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)
|
|
||
| func testMinorMajor9th() { | ||
| let notes: [Int8] = [60, 63, 67, 71, 74] | ||
| let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } ) |
There was a problem hiding this comment.
Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)
| XCTAssertEqual(chord2.description, "CmMaj7") | ||
| XCTAssertEqual(chord.map { $0.description }, ["CmMaj7"]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
| func testMinorMajor7th() { | ||
| let notes: [Int8] = [60, 63, 67, 71] | ||
| let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } ) |
There was a problem hiding this comment.
Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)
| 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 | ||
| C C# D D# E F F# G G# A Bb B C C# D D# E F F# G G# A | ||
| */ | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| let chord = Chord.getRankedChords(from: pitchSet) | ||
| XCTAssertEqual(chord.map { $0.description }, ["Cmaj9♭5"]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
| func testMajorNinthFlatFive() { | ||
| let notes: [Int8] = [60, 64, 66, 71, 74] | ||
| let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } ) |
There was a problem hiding this comment.
Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)
| let chord = Chord.getRankedChords(from: pitchSet) | ||
| XCTAssertEqual(chord.map { $0.description }, ["Cmaj7♭5"]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
| func testMajorSeventhFlatFive() { | ||
| let notes: [Int8] = [60, 64, 66, 71] | ||
| let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } ) |
There was a problem hiding this comment.
Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)
| let chord = Chord.getRankedChords(from: pitchSet) | ||
| XCTAssertEqual(chord.map { $0.description }, ["C7♭5", "F♯7♭5"]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
No description provided.