Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging visionos branch into main #87

Merged
merged 21 commits into from
Apr 20, 2024
Merged

Merging visionos branch into main #87

merged 21 commits into from
Apr 20, 2024

Conversation

maksutovic
Copy link
Collaborator

I did some testing and merging vision os changes into main is safe to do, please merge.


let size = layer.drawableSize
let w = Float(size.width)
let h = Float(size.height)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'h' (identifier_name)

updateWaveform(samples: dataCallback())

let size = layer.drawableSize
let w = Float(size.width)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'w' (identifier_name)

updateWaveform(samples: dataCallback())

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

layerRenderPassDescriptor = MTLRenderPassDescriptor()
layerRenderPassDescriptor.colorAttachments[0].loadAction = .clear
layerRenderPassDescriptor.colorAttachments[0].storeAction = .store
layerRenderPassDescriptor.colorAttachments[0].clearColor = MTLClearColorMake(0, 0, 0, 0);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Semicolon Violation: Lines should not have trailing semicolons. (trailing_semicolon)

}

var metalLayer: CAMetalLayer {
layer as! CAMetalLayer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force Cast Violation: Force casts should be avoided. (force_cast)

@aure aure merged commit 3559d8b into AudioKit:main Apr 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants