-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dplug-build Windows Installer #361
Conversation
…estimate is wrong because of the multiple install directories workaround
OK my review only contains the following:
So, I'm ready to merge without changes. |
I can work on those two cases and make a follow up PR. I think only supporting 64bit LV2 is a good idea. We could see if there is a way to gray out AAX and LV2 if the installer is being run on a 32bit machine. Then we can skip installing those formats |
This adds support for the
--installer
flag indplug-build
on Windows.Requirements
signtool.exe
to PATH variable)makensis.exe
to PATH variable)Features
signtool
from the Windows SDK to sign the resulting.exe
plugin.json additions
The windows installer uses the following fields in
plugin.json
windowsInstallerHeaderBmp
- optional 150x57 bmp image to use in the headerkeyFile-windows
- Path to PFX keyfile. Duplicated from pace.jsonkeyPassword-windows
- Password for PFX keyfile. Duplicated from pace.jsonLooking forward to review!