Don't unnecessarily borrow &self as mutable #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a breaking change under semver rules--I don't know enough to be confident.
The
get_noise
functions don't actually need to borrowself
mutably, and doing so can be somewhat limiting. For instance, I want to generate noise in parallel on multiple threads. That cannot be done with&mut self
, as Rust treats that as an indication that that function mutates some shared state within the generator, which cannot be done safely on multiple threads.However, since these functions don't actually mutate any internal state, they're perfectly safe to call from multiple threads at once--Rust just doesn't know it. That's what this PR fixes.