Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition (Shared Medicines List Authored by Practitioner) has bug in the information-recipient invariant that prohibits a device #59

Closed
3 tasks done
robeastwood-agency opened this issue Jan 21, 2020 · 2 comments
Assignees
Labels
bug This issue is a discrete error with an artefact not meeting its requirements (stated or otherwise) size/tiny ~ 1 day or less status/complete

Comments

@robeastwood-agency
Copy link
Member

Prerequisites

  • I have verified the problem exists in the available content
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title

The bug

One invariant on the optional extension Composition.extension:informationRecipient has faulty FHIRPath expression. The consequence of which is that unacceptable content for this element is always valid against this invariant.

The affected invariant is:

  • inv-dh-cmp-12: An information recipient shall not be a device

With the FHIRath expression:

resolve().where($this is Device).exists().not()

What I expected to happen

Acceptable content for this element shall be valid against these invariants.
Unacceptable content for this element shall not be valid against these invariants.

The fix

Verification of this FHIRPath pattern with targeted examples, conclude that the FHIRPath that works is of this pattern:

valueReference.reference.resolve().where($this is Device).exists().not()

Workarounds

Providing a logical reference via identifier rather than a reference to a resource.

@robeastwood-agency robeastwood-agency added action/triage This issue needs to be triaged by Clinical Informatics bug This issue is a discrete error with an artefact not meeting its requirements (stated or otherwise) size/tiny ~ 1 day or less status/not-yet-scheduled labels Jan 21, 2020
@RichardTON RichardTON added status/in-progress action/triage This issue needs to be triaged by Clinical Informatics and removed status/not-yet-scheduled action/triage This issue needs to be triaged by Clinical Informatics status/in-progress labels Jan 29, 2020
@RichardTON
Copy link
Member

This issue is accepted as a known issue due to project constraints in accordance with the following requirements:

  • this is not a mandatory element;
  • there is a functioning workaround
  • this content is not expected in the PSML use case

This behavior is accepted as a known issue and documented in the SML FHIR IG via: 2bacc4b#diff-0c3a887c600181a92b738f7c87f57860

@RichardTON RichardTON added closed/wontfix This issue is closed because we have decided not to make the suggested change and removed action/triage This issue needs to be triaged by Clinical Informatics labels Jan 29, 2020
@dbojicic-agency
Copy link
Contributor

Later versions of IG Publisher have been updated and the content validation works as expected when correct FHIRPath expressions are provided. As a result inv-dh-cmp-12 FHIRPath expressions has been updated to:
valueReference.reference.resolve().where($this is Device).exists().not()

@dbojicic-agency dbojicic-agency added status/complete and removed closed/wontfix This issue is closed because we have decided not to make the suggested change labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a discrete error with an artefact not meeting its requirements (stated or otherwise) size/tiny ~ 1 day or less status/complete
Projects
None yet
Development

No branches or pull requests

3 participants