Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cure diseases when polymorphed #359

Merged
merged 10 commits into from
May 23, 2018

Conversation

AquariusPower
Copy link
Contributor

actually fix DeActivateTemporaryState() to also do it on the polymorph backup

but what we will see is when talking to the priest/god for a cure,
and player is still polymorphed in a werewolf,
after the polymorphing ends, lycantrophy (poison, leprosy etc based on what you paid for) will also all have been removed from the human form.

I think that was clearly a bug and not a difficulty thing, that looked like it was really missing right?

when exiting and entering a dungeon subsequently many times
before saving by exiting to main menu at least once,
the CurrentSavefileVersion will be set to SAVE_FILE_VERSION on a new game.
@AquariusPower
Copy link
Contributor Author

I also throwed in here this fix (commit log):
added a fix, when a new game is started,
when exiting and entering a dungeon subsequently many times
before saving by exiting to main menu at least once,
the CurrentSavefileVersion will be set to SAVE_FILE_VERSION on a new game.

PS.: if you perfer I can separate it in another PR.

@ryfactor
Copy link
Member

added a fix, when a new game is started,
when exiting and entering a dungeon subsequently many times
before saving by exiting to main menu at least once,
the CurrentSavefileVersion will be set to SAVE_FILE_VERSION on a new game.

Does this fix the bug you described in #342, about the crash on the levels with lions and bears, described here?:

when it randomly happens, when going to gloomy caves the 1st time after playing a lot even at XT, I get this backtrace (about light emmiters, and this is about the 3rd time) I still dont know how to fix it!

It looks like a standalone bug fix to me

@AquariusPower
Copy link
Contributor Author

No, that fix for the CurrentSavefileVersion is just that the default value was -1 wainting to be set by a load game stack trace. The New game stack trace has no load therefore it was not being set.

that #342 is about light emitters and I didnt looked that code in detail yet, mostly becase it is random, happens rarely and the new safe savegame is able to counter (woraround) it and probably other difficult situations.

Should I split CurrentSavefileVersion issue in another PR?

@ryfactor
Copy link
Member

Should I split CurrentSavefileVersion issue in another PR?

Nah, let's just merge

@ryfactor ryfactor merged commit d41964b into Attnam:master May 23, 2018
@AquariusPower AquariusPower deleted the FixCureDiseasesWhenPolymorphed branch May 24, 2018 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants