Fix world ratio oversight #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for dynamically modifying the values
…ment if name not present (or 1 if nothing is present)
AtriusX
added
enhancement
NewbieOrange
added a commit
to NewbieOrange/Waystones
that referenced
this pull request
Sep 4, 2021
This PR is missing translation for `HOW_LOW_CAN_YOU_GO` since it is unused and without context I am not sure how to translate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily aims to fix an issue with world ratios working primarily off of world names and not dimension type. Both functionalities are useful in different ways, so this updates the system to make use of both approaches. When retrieving a ratio, the ratio will first attempt to retrieve by world name, and then by dimension type if no ratio is set.
An additional side effect of this change is that it's now possible to modify the world ratios file via a new command. This will make configuration of this system much more accessible to admins who do not have file system access. This also results in the inclusion of a new permission:
waystones.ratio.