Update command to handle /waystones getkey from console. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Afaik the current impl is the most flexible way (support plural of different languages, etc.) to handle parameters in localization without relying on (very heavy, i.e. ICU4j) third-party libraries, but there might be some lightweight localization libraries that I am not aware of. |
|
Alright, we'll stick with the current solution until a better one presents itself then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem discussed in #30. The code still needs testing and a localization update.
@NewbieOrange could you provide a translation for
command-bad-sender? I'm also wondering if there is a better way to handle the parameters with the localizations, it's not immediately clear.