Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugfix for seemingly unused config option jump-worlds #28

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

AtriusX
Copy link
Owner

@AtriusX AtriusX commented Jun 14, 2021

This PR fixes a small problem related to the jump-worlds config option being apparently unused. This option should disable warping between dimensions completely if set to false.

This PR is mostly completed, however it adds another message to the plugin named world-jump-disabled that is used when a warp to another dimension is denied. Localization is still needed for Chinese language support.

@AtriusX AtriusX added the bug Something isn't working label Jun 14, 2021
@AtriusX
Copy link
Owner Author

AtriusX commented Jun 14, 2021

@NewbieOrange Are you available to provide a translation for the added message?

@NewbieOrange
Copy link
Contributor

Sure, see #29.

@AtriusX
Copy link
Owner Author

AtriusX commented Jun 14, 2021

Great thanks!

@AtriusX AtriusX merged commit 6b48162 into master Jun 14, 2021
@AtriusX AtriusX deleted the fix/jump-worlds branch June 14, 2021 18:43
@AtriusX AtriusX restored the fix/jump-worlds branch June 28, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants