Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Feature - filter access to add and delete doctor base on role #16

Merged
merged 4 commits into from
Oct 1, 2023
Merged

PR: Feature - filter access to add and delete doctor base on role #16

merged 4 commits into from
Oct 1, 2023

Conversation

lordksix
Copy link
Collaborator

@lordksix lordksix commented Oct 1, 2023

In this PR, the changes are as follows:

  • Implement Protected route base on roles
  • Implement Route for unauthorized request by users
  • Improve layout of sidebar for mobile screen
  • Implement selective rendering on the side for routes to add and delete doctors.

@lordksix lordksix requested a review from Atril33 October 1, 2023 17:37
misalazeem
misalazeem approved these changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@misalazeem misalazeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lordksix,

Your changes look good to me. Its time to merge it 🥳 🥳

Highligts:

  • No linter Errors
  • Good PR description

Good luck and Happy coding.
If you have any questions you can reach out to me

@lordksix lordksix removed the request for review from Atril33 October 1, 2023 19:33
@lordksix lordksix merged commit acb8004 into dev Oct 1, 2023
3 checks passed
@lordksix lordksix deleted the feature/filter-access-add-delete-doc-role branch October 1, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misalazeem misalazeem misalazeem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lordksix @misalazeem @andrianarivo