This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Handle fatal syntax errors gracefully #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcanemagus
suggested changes
May 18, 2017
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## Upcoming | |||
There was a problem hiding this comment.
Changelog here is generated automatically during release, so this should be removed.
spec/worker-helpers-spec.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| 'use babel' | |||
|
|
|||
| import * as Path from 'path' | |||
| import * as Helpers from '../src/worker-helpers' | |||
| import * as Helpers from '../src/worker/helpers' | |||
There was a problem hiding this comment.
There is no need to rearrange the files here.
src/helpers.js
Outdated
| }) => { | ||
| const message = fatal ? originalMessage.split('\n').shift() : originalMessage |
There was a problem hiding this comment.
Since the Array being created here is being discarded within the same command, just do [0] on the end, it's clearer what the intent is.
Arcanemagus
approved these changes
May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint outputs context in the most recent versions which is useless inside Atom
Can be seen in a lot of issues across the repos, steelbrain/linter-ui-default#309 is the most recent one