This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Remove custom styling #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forced styling being done before was breaking on several themes, to the point where some were unreadable. This removes the badge styling and instead lets the theme handle the URL as a simple link. Rule name is moved to the end of the message, similar to ESLint's CLI output.
Arcanemagus
force-pushed
the
arcanemagus/clean-style
branch
from
aec966d to
f13cf59
Compare
IanVS
approved these changes
Feb 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forced styling being done before was breaking on several themes, to the point where some were unreadable. This removes the badge styling and instead lets the theme handle the URL as a simple link. Rule name is moved to the end of the message, similar to ESLint's CLI output.
For example in my current theme this is what it looks like before this PR:
And after:
Fixes #482.