This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Convert null to empty string inside path.dirname() #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tensor5 sorry, but it looks like there is a merge conflict. If you could rebase this, I'll be happy to merge since it's obviously causing some people some pain. |
tensor5
force-pushed
the
path-type-check
branch
from
4a9ca1e to
ad82240
Compare
|
@IanVS, please try now. |
|
No merge conflicts locally, and this fixes an issue with the upcoming Electron upgrade in Atom so I'm forcing a merge, thanks! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580.