Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Add URIs for documentation of plugins #562

Merged
merged 1 commit into from
May 3, 2016

Conversation

relekang
Copy link
Contributor

@relekang relekang commented May 1, 2016

This makes the link to rule documentation work for the plugins used by the airbnb preset.

@relekang
Copy link
Contributor Author

relekang commented May 1, 2016

Should I add some more?

@relekang relekang force-pushed the add-links-for-plugins branch from b28152d to f6f1dc0 Compare May 1, 2016 18:58
@Arcanemagus
Copy link
Member

Could you update the logic to similar to here, but use a switch statement with a default case leading to here?

@Arcanemagus
Copy link
Member

And please add as many as you want!

* eslint-plugin-react
* eslint-plugint-import
* eslint-plugin-jsx-a11y
* eslint-plugin-lodash
* eslint-plugin-ava
* eslint-plugin-mocha
* eslint-plugin-angular
* eslint-plugin-import-order
* eslint-plugin-jasmine
* eslint-plugin-promise
@relekang relekang force-pushed the add-links-for-plugins branch from f6f1dc0 to 364d4ec Compare May 2, 2016 19:34
@relekang
Copy link
Contributor Author

relekang commented May 2, 2016

Sure, just updated it :)

@Arcanemagus
Copy link
Member

@AtomLinter/linter-eslint Any further changes? This LGTM.

@IanVS
Copy link
Member

IanVS commented May 3, 2016

I love it. Thanks, @relekang!

@IanVS IanVS merged commit eab22f7 into AtomLinter:master May 3, 2016
@IanVS
Copy link
Member

IanVS commented May 3, 2016

Shoot, I merged and then realized we're missing the src version. The PR only had the compiled lib file, which will be overwritten as soon as someone compiles from source.

Since it was my mistake, I'll make a commit to fix things up.

@Arcanemagus we should find a way to prevent this in the future.

IanVS added a commit that referenced this pull request May 3, 2016
I merged #562 too quickly before realizing that there were no `src` file
changes, only changes to `lib`, which would have been overwritten the
first time someone else compiled `src` to `lib`.  This commit brings
@relekang’s contribution over to the `src` file with a few minor
modifications to meet our linting rules.
IanVS added a commit that referenced this pull request May 3, 2016
I merged #562 too quickly before realizing that there were no `src` file
changes, only changes to `lib`, which would have been overwritten the
first time someone else compiled `src` to `lib`.  This commit brings
@relekang’s contribution over to the `src` file with a few minor
modifications to meet our linting rules.
IanVS added a commit that referenced this pull request May 3, 2016
I merged #562 too quickly before realizing that there were no `src` file
changes, only changes to `lib`, which would have been overwritten the
first time someone else compiled `src` to `lib`.  This commit brings
@relekang’s contribution over to the `src` file with a few minor
modifications to meet our linting rules.
@relekang
Copy link
Contributor Author

relekang commented May 3, 2016

Oh, how did I miss this. Sorry about that and thank you for fixing it.

@Arcanemagus
Copy link
Member

Published in v7.2.2, thanks again @relekang!

@relekang relekang deleted the add-links-for-plugins branch May 3, 2016 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants