-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show stack trace info in the cargo test output #24
Conversation
This was explicitly enabled by another user: b8bc438 I'd suggest you add it as an option. |
Its not always the assert that panics. Therefore I would like to be able to see the backtrace. An option would be OK for me. :-) |
I'll update this to be an option later, I agree it should be. However I will argue that it should be off by default. |
The option should also change this Default=Off is ok for me. Cargos default is off too. |
Cool. Off by default sounds good. |
This almost works, but the settings change doesn't get picked up until next load. I'm new to atom packages, how do you fix this? |
@noseglid also, off topic but, do you know how to make the output colored? This is really the only thing I miss about using the terminal directly. |
@colin-kiegel that's unfortunate. |
@@ -55,6 +67,7 @@ export function provideBuilder() { | |||
{ | |||
name: 'Cargo: build (debug)', | |||
exec: cargoPath, | |||
env: env, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be set for all commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was a good idea, but I can see arguments either way.
The other way to get colors enables is to spawn the commands in a pseudo terminal, and this it "thinks" it's running an environment which supports colors, control sequences, terminfo etc. This is something I'm looking to solve in the Regarding the update of the configuration. It doesn't update because I have written documentation on creating build providers. To make the update happen automatically you would in essence need to:
This should cause |
Is this something that should be done for all settings in another PR? |
I'm absolutely fine with merge this as is, if you'd rather do it in another pr/not at all :) |
Yea if you don't mind, I'm not sure when I'll get around to the settings update stuff. |
Don't show stack trace info in the cargo test output
The general case for testing is to check for failures vs successes, with information about what failed given by a call to something like
assert!
. Stack trace information can be useful but often isn't.