Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: TS improvements and fixes #245

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Fix: TS improvements and fixes #245

merged 4 commits into from
Nov 2, 2021

Conversation

thomasdigby
Copy link
Member

@thomasdigby thomasdigby commented Nov 2, 2021 •
edited
Loading

  • Removed hard-coded size type from Heading and Text - We're constraining the valid props for size by using our own, and removing the ability to use media queries e.g. <Heading size={{ '@initial': 'sm', '@md': 'lg' }} />
  • Removed unnecessary align and direction variants applying when <Label type="block" />

@thomasdigby thomasdigby requested a review from LeahB8 November 2, 2021 15:34
@thomasdigby thomasdigby merged commit 0d68a61 into main Nov 2, 2021
@thomasdigby thomasdigby deleted the fix/ts-improvments-misc-fixes branch November 2, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollg hollg hollg approved these changes

@LeahB8 LeahB8 Awaiting requested review from LeahB8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasdigby @hollg