Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Shared Pool being closed/destroyed when one of the broadcasters is destroyed #918

Closed
sharathp opened this issue Feb 20, 2013 · 0 comments
Labels

Comments

@sharathp
Copy link

With Redis Shared Pool enabled:

org.atmosphere.plugin.redis.RedisBroadcaster.sharedPool = true

When one of the broadcasters is destroyed, it is closing the entire Shared Pool which is causing the next subsequent broadcasts to fail because of the closed pool.

RedisUtil: (line 136)

public void destroy() {
        Object lockingObject = getLockingObject();
        synchronized (lockingObject) {
            try {
                disconnectPublisher();
                disconnectSubscriber();
                if (jedisPool != null) {
                    jedisPool.destroy();
                }
            } catch (Throwable t) {
                logger.warn("Jedis error on close", t);
            } finally {
                config.properties().put(REDIS_SHARED_POOL, null);
            }
        }
    }
jfarcand added a commit that referenced this issue Feb 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants