Missing shutdown of asyncSupport in case of fallback to other implementation

[javaguru-ch]

If an instance of Tomcat7AsyncSupportWithWebSocket is created first and later on replaced with an instance of Tomcat7BIOSupportWithWebSocket, the first instance is not destroyed.

Log:

12:35:47.533 WARN o.atmosphere.cpr.AtmosphereFramework - Failed using comet support: org.atmosphere.container.Tomcat7AsyncSupportWithWebSocket, error: Tomcat failed to detect this is a Comet application because context.xml is missing or the Http11NioProtocol Connector is not enabled.
If that's not the case, you can also remove META-INF/context.xml and WEB-INF/lib/atmosphere-compat-tomcat.jar Is the Nio or Apr Connector enabled?
12:36:24.470 WARN o.atmosphere.cpr.AtmosphereFramework - Using org.atmosphere.container.Tomcat7BIOSupportWithWebSocket

The problem lies in class AtmosphereFramework on line 1303:

asyncSupport = asyncSupport.supportWebSocket() ? new Tomcat7BIOSupportWithWebSocket(config) : new BlockingIOCometSupport(config);

Before replacing the current (not working) asyncSupport, it should be shut down to ensure all resources (i.e. ExecutorService) are properly shut down.
A possible solution would be to replace the above line with the following code:

AsyncSupport current = asyncSupport;
asyncSupport = asyncSupport.supportWebSocket() ? new Tomcat7BIOSupportWithWebSocket(config) : new BlockingIOCometSupport(config);
if(current instanceof AsynchronousProcessor) {
    ((AsynchronousProcessor)current).shutdown();
}

[jfarcand]

Good catch! Testing it.

[jfarcand]

Thanks! Adding in 1.1-SNAPSHOT