[jQuery] firefox, ESC key closes request

[PavelR577]

Used this fix (I think we can add it to the atmosphere JS by default)

jQuery(document).ready(function(){
jQuery(this).keypress(function(e){
        if(e.keyCode == 27){
            e.preventDefault();
        }
    });
});

[jfarcand]

Nice catch. Thanks!

[blabno]

This fix should be placed in atmosphere.js and not jquery.atmosphere.js.

[jfarcand]

It;s there https://github.com/Atmosphere/atmosphere-javascript/blob/master/modules/javascript/src/main/webapp/javascript/atmosphere.js#L3009-L3014

[blabno]

@jfarcand oh, thank you, but it doesn't work if I have jQuery loaded. I'm using pure atmosphere.js but I also have jQuery library loaded for some other stuff.

[flowersinthesand]

Because event.which property is provided by jQuery.

event.which should be replaced with event.charCode != null ? event.charCode : event.keyCode and also event.preventDefault should be checked if it exists first since old IE doesn't have it.

I'll commit them.

[jfarcand]

OK Thanks will play a little with it.

[flowersinthesand]

The patch applies on the master branch from atmosphere-javascript.

Atmosphere/atmosphere-javascript@48e6a47

For your information, it is fixed in Firefox 20.

[jfarcand]

Woa Thanks!!! I will port it to the branch!