Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin JQuery not compatible with RequireJS #378

Closed
mjeanroy opened this issue May 24, 2012 · 2 comments
Closed

Plugin JQuery not compatible with RequireJS #378

mjeanroy opened this issue May 24, 2012 · 2 comments

Comments

@mjeanroy
Copy link
Contributor

Plugin JQuery for Atmosphere is not compatible with RequireJS (AMD Loader for Javascript).

This error is thrown : Uncaught TypeError: Property '$' of object [object Window] is not a function

Problematic line is 470.

The simplest way to fix this is to use 'jQuery' instead of shortcut '$' everywhere.
I can do more tests to confirm.
jfarcand added a commit that referenced this issue May 24, 2012
@jfarcand
Fix for #378 Plugin JQuery not compatible with RequireJS
1327686
@jfarcand
Copy link
Member

OK fixed in 1.0.0-SNAPHOT. Can you try it and confirm? Thanks!

@mjeanroy
Copy link
Contributor Author

OK, it seems to be fixed!

jfarcand added a commit that referenced this issue May 29, 2012
@jfarcand
Port fix for #382 #296 #378
50ef9c3
jfarcand added a commit that referenced this issue May 30, 2012
@jfarcand
Fix for #378 Plugin JQuery not compatible with RequireJS
f59d71b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfarcand @mjeanroy