AtmosphereInterceptor.postInspect() is not called in case of a handler thrown exception

[reda-alaoui]

Hi,

Today, it seems that there is no guarantee that AtmosphereInterceptor.postInspect() be called after each AtmosphereInterceptor.inspect().

Indeed, there is no try/finally in AynchronousProcessor:

// handler interceptor lists
        Action a = invokeInterceptors(handlerWrapper.interceptors, resource, tracing);
        if (a.type() != Action.TYPE.CONTINUE && a.type() != Action.TYPE.SKIP_ATMOSPHEREHANDLER) {
            return a;
        }

        // Remap occured.
        if (req.getAttribute(FrameworkConfig.NEW_MAPPING) != null) {
            req.removeAttribute(FrameworkConfig.NEW_MAPPING);
            handlerWrapper = map(req);
            if (handlerWrapper == null) {
                logger.debug("Remap {}", resource.uuid());
                throw new AtmosphereMappingException("Invalid state. No AtmosphereHandler maps request for " + req.getRequestURI());
            }
            resource = configureWorkflow(resource, handlerWrapper, req, res);
            resource.setBroadcaster(handlerWrapper.broadcaster);
        }

        //Unit test mock the request and will throw NPE.
        boolean skipAtmosphereHandler = req.getAttribute(SKIP_ATMOSPHEREHANDLER.name()) != null
                ? (Boolean) req.getAttribute(SKIP_ATMOSPHEREHANDLER.name()) : Boolean.FALSE;
        if (!skipAtmosphereHandler) {
            try {
                logger.trace("\t Last: {}", handlerWrapper.atmosphereHandler.getClass().getName());
                handlerWrapper.atmosphereHandler.onRequest(resource);
            } catch (IOException t) {
                resource.onThrowable(t);
                throw t;
            }
        }

        postInterceptors(handlerWrapper.interceptors, resource);

This prevent us to make use of AtmosphereInterceptor like we do with javax.servlet.Filter.
Is it possible to add the try/finally? Something prevents us from doing it?

[reda-alaoui]

Or at least an AtmosphereInterceptor.onThrowable() method?

[jfarcand]

Fix

[reda-alaoui]

Thank you !

[reda-alaoui]

There is still an issue, even with my correction.
Incoming pull request.