Possible Thread Race with AsyncToken in DefaultBroadcaster

[jfarcand]

In DefaultBroadcaster, setAttribute is called with the same key:

request.setAttribute(ASYNC_TOKEN, token);

This can cause side effect if more than one Broadcaster is used with the same AtmosphereResource

[slovdahl]

This issue is marked as fixed in 2.2.7, but I can't find any commit that fixes it in the atmosphere-2.2.x branch.

[jfarcand]

@slovdahl If you have the cycle, just cherry-pick it. Thanks!

[slovdahl]

Sure, will do.

[slovdahl]

Should we let the public void cacheLostMessage(AtmosphereResource r) method be available in 2.2.x? It's a bit dangerous to remove a public method.

[jfarcand]

+1

[slovdahl]

Hmm, can't find that wiki page or mail where you said which :symbol: to use for commits 🐫

[jfarcand]

https://github.com/Atmosphere/atmosphere/wiki/For-Committers