Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending a pipe ('|') with streaming causes a javascript exception #1479

Closed
Artur- opened this issue Feb 21, 2014 · 7 comments
Closed

Sending a pipe ('|') with streaming causes a javascript exception #1479

Artur- opened this issue Feb 21, 2014 · 7 comments

Comments

@Artur-
Copy link
Contributor

Artur- commented Feb 21, 2014

See http://artur.app.fi/vaadin-uitest-7.2.0.dev-526aa193437e667124a652a8a7c870fe9a0ec501-178/run/BarInUIDL?debug&restartApplication.

Tested using jquery javascript 2.1.4. Works at least in 2.0.3

@jfarcand
Copy link
Member

@Artur- This is expected, the | is what is used by the TrackMessageSizeInterceptor. You need to change the value in web.xml

@Artur-
Copy link
Contributor Author

Artur- commented Feb 24, 2014

I can't know what character will not be included in a message in e.g. a chat or if pushing some binary data.

As said, this is a regression in 2.1

@jfarcand
Copy link
Member

@Artur- I don't think this is a regression...this hasn't changed between released version. You may have added a workaround in your code (this is what I suspect). I recommend you use something like @@<> or a strange char like that.

You may want to use the b64 interceptor, but performance wise it is slower.

@Artur-
Copy link
Contributor Author

Artur- commented Feb 24, 2014

The problem is 0770b52 which prevents addition of any length information to the message when it contains a | or whatever character is used. So it's actually a regression in atmosphere-runtime.

@jfarcand
Copy link
Member

@Artur- Ha I see. But the client may fail IMO because of the multiple char. Let me debug it more closely.

@jfarcand jfarcand reopened this Feb 24, 2014
@jfarcand jfarcand added 2.1.1 and removed not a bug labels Feb 24, 2014
jfarcand added a commit that referenced this issue Feb 24, 2014
@jfarcand
Copy link
Member

Good catch, this is clearly a regression. Fixed by now.

@jfarcand
Copy link
Member

Note that this issue is only with Atmosphere 2.1.0, not 2.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants