Atmosphere's HttpServletRequest.getRequestURI() must never return null in all circumstances

[ceefour]

Affects v1.0.13.

As the correct behavior is depended upon by on wicket-atmosphere https://issues.apache.org/jira/browse/WICKET-5282

@papegaaij noted that:

The NPE is caused by a null url returned by HttpServletRequest.getRequestURI. Atmosphere provides the implementation of this HttpServletRequest. It seems this implementation can return null under some circumstances, which is a violation of the spec. It is likely to be related to the 'Request is no longer valid' warning. This should probably be reported upstream.

If Atmosphere cannot handle getRequestURI() call properly, it should throw a "real" Exception instead of returning null.

[jfarcand]

Which transport produce this NPE?

[ceefour]

WebSocket using tomcat 7.0 on linux64.
Atmosphere-compat-tomcat7 is excluded from maven.
On Aug 22, 2013 7:55 PM, "Jeanfrancois Arcand" notifications@github.com
wrote:

Which transport produce this NPE?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1246#issuecomment-23087578
.

[ceefour]

Souvik Bhattacharya added a comment - 27/Aug/13 14:07

I am able to generate the error multiple time in my application. In my application I push through EventBus.post frequently(in every 3 seconds) and if second request come to @subscribe before the completion of first request then it's throwing error. If needed I can share my screen as well

[jfarcand]

Looking today...

[jfarcand]

So far I can't reproduce tha issue using 1.0.16 :-( @ceefour can you try?

[jfarcand]

Ok I can see where it happens. Fix in process...

[ceefour]

Thank you @jfarcand , so this will be in 1.0.17 ?