Setting org.atmosphere.websocket.maxIdleTime property closes the websocket connection as soon as it is opened.

[jbhavaraju]

We are using atmosphere version 1.1.0.RC1 for websockets over Tomcat and it looks like the TomcatWebsocketHandler is not handling the maxIdleTime property correctly.

From org.atmosphere.container.TomcatWebsocketHandler,

String s = framework.getAtmosphereConfig().getInitParameter(ApplicationConfig.WEBSOCKET_IDLETIME);
if (s != null) {
webSocketWriteTimeout = Integer.valueOf(1);
} else {
webSocketWriteTimeout = -1;
}

It looks like the timeout value is getting overwritten to 1 millisecond if the property is set at all. The end effect is that the connection gets dropped as soon as it is established

[jfarcand]

Good finding. Fixed in both version.

[jbhavaraju]

Hey, Thanks for fixing it so promptly. But I'm confused, maven central has 1.1.0.RC1, and I don't see a tag here in git for RC1. I see you applied the fix to 1.0.x so, does that mean I have to merge your fix into RC1 ?

thanks !

j

[jfarcand]

The main branch is master, e.g 1.1.0-SNAPSHOT