[jquery.atmosphere.js] problem using streaming transport in IE6 with trackMessageLength

[robert1111]

Environment: ie6 + streaming transport, with trackMessageLength set to true

Problem:
Every time a message arrives, the onMessage handler will be invoked twice: The first message got from onMessage is the size of the received message (added by TrackMessageSizeInterceptor or TrackMessageSizeFilter).

Fix (master):
Line: 1939 - 1945

                                            var skipCallbackInvocation = _trackMessageSize(text, rq, _response);

                                            if (!skipCallbackInvocation && !_handleProtocol(rq, _response.responseBody)){
                                                return "";
                                            }
                                        }

                                        if (!skipCallbackInvocation) _prepareCallback(text, "messageReceived", 200, rq.transport);

change to:

                                            var skipCallbackInvocation = _trackMessageSize(text, rq, _response);

                                            if (!skipCallbackInvocation && !_handleProtocol(rq, _response.responseBody)){
                                                return "";
                                            }
                                            if (!skipCallbackInvocation) _prepareCallback(_response.responseBody, "messageReceived", 200, rq.transport);
                                        }

The first parameter of the _prepareCallback function should be _response.responseBody instead of text.

[jfarcand]

Which verison of Atmosphere are you using?

[jfarcand]

Ah. Just saw you are using Master. Have you tested with other IE version by any chance?

[jfarcand]

Fixed. Thanks!

[robert1111]

I tried 1.0.12 and 1.1.0.RC1, both have the same problem, which also exists in Master as i examined the code.

BTW, I think it's better to move the line you fixed to the inner braces of

if (text.length != 0) {
    ...
}

(up one brace) since the variable skipCallbackInvocation is declared there, and _prepareCallback has to be invoked only when there is text content;-)

[jfarcand]

OK my bad. Fixed in master. But I'm unable to reproduce the issue with 1.0.12,