Fix for #242 Atmosphere&Jersey: Problem with using the session, Fix for

#230 [runtime][jetty] Session lost on first request
Atmosphere · Mar 27, 2012 · 3c1f151 · 3c1f151
1 parent 76d48a3
commit 3c1f151
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/modules/cpr/src/main/java/org/atmosphere/container/JettyWebSocketHandler.java b/modules/cpr/src/main/java/org/atmosphere/container/JettyWebSocketHandler.java
@@ -223,7 +223,7 @@ public JettyRequestFix(AtmosphereRequest request) {
             this.serverPort = request.getServerPort();
 
             HttpSession session = request.getSession(true);
-            httpSession = new FakeHttpSession(session.getId(), session.getServletContext(), session.getCreationTime());
+            httpSession = new FakeHttpSession(session);
 
             Enumeration<String> e = request.getHeaderNames();
             String s;

diff --git a/modules/cpr/src/main/java/org/atmosphere/cpr/AtmosphereRequest.java b/modules/cpr/src/main/java/org/atmosphere/cpr/AtmosphereRequest.java
@@ -76,7 +76,7 @@ public class AtmosphereRequest implements HttpServletRequest {
     private AtmosphereRequest(Builder b) {
         pathInfo = b.pathInfo == "" ? b.request.getPathInfo() : b.pathInfo;
         session = b.request == null ?
-                new FakeHttpSession("", null, System.currentTimeMillis()) : b.request.getSession();
+                new FakeHttpSession("", null, System.currentTimeMillis(), -1) : b.request.getSession();
 
         if (b.inputStream == null) {
             if (b.dataBytes != null) {

diff --git a/modules/cpr/src/main/java/org/atmosphere/util/FakeHttpSession.java b/modules/cpr/src/main/java/org/atmosphere/util/FakeHttpSession.java
@@ -29,10 +29,16 @@ public class FakeHttpSession implements HttpSession {
     private final ServletContext servletContext;
     private int maxInactiveInterval;
 
-    public FakeHttpSession(String sessionId, ServletContext servletContext, long creationTime) {
+    public FakeHttpSession(String sessionId, ServletContext servletContext, long creationTime, int maxInactiveInterval) {
         this.sessionId = sessionId;
         this.servletContext = servletContext;
         this.creationTime = creationTime;
+        this.maxInactiveInterval = maxInactiveInterval;
+    }
+
+    public FakeHttpSession(HttpSession session) {
+        this(session.getId(), session.getServletContext(), session.getLastAccessedTime(), session.getMaxInactiveInterval());
+        copyAttributes(session);
     }
 
     public void destroy() {
@@ -115,6 +121,16 @@ public void removeValue(String name) {
         attributes.remove(name);
     }
 
+    public FakeHttpSession copyAttributes(HttpSession httpSession){
+        Enumeration<String> e = httpSession.getAttributeNames();
+        String k;
+        while(e.hasMoreElements()) {
+            k = e.nextElement();
+            attributes.put(k, getAttribute(k));
+        }
+        return this;
+    }
+
     // TODO: Not supported for now.
     @Override
     public void invalidate() {