Lipkau feature/get edit medta #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into lipkau-feature/GetEditMedta
Test was failing because ConvertFrom-Json2 is not defined as public, so it wasn't a known PS command when the test was run outside the scope of the module.
There was an extra bracket at the end of the JSON {found using an external JSON tool).
Also reduced the number of spaces in the JSON for convenience.
|
Failure here is due to an issue deploying the PR to PSGallery; the Pester tests passed. I'll need to debug that a bit to see if I can figure out what's wrong there, but I'm going to go ahead and merge this in the mean time since that's a build system issue, not a problem with this code. |
|
Successfully deployed in build 1.2.5.145. Must be a quirk of AppVeyor in a PR...apparently it doesn't have access to AppVeyor's encrypted data when a build is triggered by a PR? Oh, well. CI is fun and all that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated from PR #59. Tests have been updated and should be passing now.