Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #367: Incorrect Resolving Of User #369

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Fix #367: Incorrect Resolving Of User #369

merged 3 commits into from
Aug 15, 2019

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Aug 15, 2019

Description

Added better handling for resolving the user from an object or a string

Motivation and Context

closes #367

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau lipkau requested review from a team as code owners August 15, 2019 14:42
@lipkau lipkau changed the title Fix/#367 incorrect resolving of user Fix #367: Incorrect Resolving Of User Aug 15, 2019
@lipkau lipkau changed the base branch from master to develop August 15, 2019 14:42
brianbunke
brianbunke approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@brianbunke brianbunke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lipkau lipkau merged commit 6eaa170 into AtlassianPS:develop Aug 15, 2019
@lipkau lipkau deleted the fix/#367-IncorrectResolvingOfUser branch August 15, 2019 21:29
@lipkau lipkau added this to the v2.11 milestone Aug 15, 2019
@lipkau lipkau self-assigned this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianbunke brianbunke brianbunke approved these changes

Assignees

@lipkau lipkau

Labels
Area:Module Issue:Bug
Projects
None yet
Milestone
v2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@lipkau @brianbunke