Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect handling of skip notifications #339

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Fix incorrect handling of skip notifications #339

merged 1 commit into from
Feb 21, 2019

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Feb 21, 2019

Description

false in the get parameter notifyUsers=false must be lowercase

Motivation and Context

closes #338

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau lipkau added this to the Next Minor milestone Feb 21, 2019
@lipkau lipkau self-assigned this Feb 21, 2019
@lipkau lipkau requested review from a team as code owners February 21, 2019 20:19
@ghost ghost added the Status:In Review label Feb 21, 2019
@lipkau lipkau changed the base branch from master to develop February 21, 2019 20:19
brianbunke
brianbunke approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@brianbunke brianbunke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lipkau lipkau merged commit 7ec4a10 into develop Feb 21, 2019
@ghost ghost removed the Status:In Review label Feb 21, 2019
@lipkau lipkau deleted the fix/#338-IncorrectHandlingOfSkipNotifications branch February 21, 2019 20:29
@lipkau lipkau mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianbunke brianbunke brianbunke approved these changes

Assignees

@lipkau lipkau

Labels
Area:Module Issue:Bug
Projects
None yet
Milestone
v2.10
Development

Successfully merging this pull request may close these issues.
2 participants
@lipkau @brianbunke