Get-JiraIssueAttachmentFile: Set Accept header based on Mime time of attachment #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The attachment objects have a
MimeType
property. This should be used to set theAccept
header in the request to download the actual attachment; however the existing code refers to (non-existing)MediaType
property on the Powershell object, thereby setting the Accept header value to null.Motivation and Context
A partial fix for apparently "successful" download of file attachments. Without this change the pipeline output is
True
for each attachment downloaded, but the attachment did not download. This PR doesn't change the fautly error handling, but implements a trivial underlying fix to constructing the request to fetch the download.I believe that the error handling code needs to be fixed too, but I've not had a chance to do that.
Types of changes
Checklist