Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI with Azure Pipelines #317

Merged
merged 12 commits into from
Dec 5, 2018
Merged

Set up CI with Azure Pipelines #317

merged 12 commits into from
Dec 5, 2018

Conversation

azure-pipelines[bot]
Copy link
Contributor

@azure-pipelines azure-pipelines bot commented Oct 18, 2018

@azure-pipelines azure-pipelines bot requested review from a team as code owners October 18, 2018 09:19
@ghost ghost added the Status:In Review label Oct 18, 2018
@ghost ghost assigned lipkau Oct 19, 2018
@kaylangan
Copy link

I'm a Program Manager on Azure Pipelines. Let me know if you have any questions or suggestions. I'm happy to help!

@Dejulia489
Copy link
Contributor

@lipkau ,
I am the Author of AzurePipelinesPS. I have my AzurePipelinesPS pipeline setup in Azure Pipelines. Let me know if you need any assistance.

@lipkau
Copy link
Member

lipkau commented Oct 20, 2018

Thank you, @kaylangan .
I am really enjoying working with VSTS.
But I found 2 things which are bugging me a bit:

  • I tag the commit which was released in the git(hub) repo in the last step of the CI/CD. And as the "release pipeline" does not have a task for cloning the repository, nor a variable of the commit which is being built (so that I can manually fetch the right commit), I am unable to use the "release pipeline" for deploying my project - I have to do it as a conditional step in the "build pipeline"
  • I am unable to get PRs working (permissions wise) if a VSTS project was not created with the github app. This is due to PRs being run with a (variable) user context which does not have permissions to upload build artifacts. I have reported the problem here: https://developercommunity.visualstudio.com/content/problem/350702/uploading-artifacts-user-is-not-authorized-to-acce.html

This is all the feedback I have for now. But I really appreciate the product and the upgrade free tier you provide. Helps a lot for hobby projects, like this/these one/s.

@lipkau
Copy link
Member

lipkau commented Oct 20, 2018

@Dejulia489 :
why don't you put your pipeline in the pipeline yaml file? or delete the file from the repo?

lipkau
lipkau previously approved these changes Oct 22, 2018
@Dejulia489
Copy link
Contributor

@lipkau, I built my build pipeline from a json template with AzurePipelinesPS. I have update my yml to reflect my build.

@shashban
Copy link

  • I tag the commit which was released in the git(hub) repo in the last step of the CI/CD. And as the "release pipeline" does not have a task for cloning the repository, nor a variable of the commit which is being built (so that I can manually fetch the right commit), I am unable to use the "release pipeline" for deploying my project - I have to do it as a conditional step in the "build pipeline"

For adding "tag a commit" in the release pipeline, you can use the variable Release.Artifacts.{alias}.SourceVersion

@davidstaheli
Copy link

Update: the ability to upload build artifacts from a fork PR build should be available in Azure Pipelines production by the end of next week (November 9) - hopefully sooner.

@lipkau
Copy link
Member

lipkau commented Oct 30, 2018

thank you for the hint, @shashban .

If I understand you correctly, I should be able to open the repo on the correct commit with something like this:

git -c http.extraheader="AUTHORIZATION: basic ***" -progress clone .....
git checkout --progress --force $(Release.Artifacts.{alias}.SourceBranch)

is this correct?

@lipkau
Copy link
Member

lipkau commented Oct 30, 2018

Thank you so much for the update @davidstaheli .
I was visiting this ticket daily to check on this :-P
https://developercommunity.visualstudio.com/content/problem/350007/build-from-github-pr-fork-error-tf400813-the-user-1.html

@davidstaheli
Copy link

😄 I'm glad you brought it up, @lipkau! I'll be sure to update that ticket and the one it links to as soon as this is available everywhere.

@lipkau
Copy link
Member

lipkau commented Nov 26, 2018

@davidstaheli : any news regarding the release?

@davidstaheli
Copy link

Hi @lipkau. Thanks for your patience. Unfortunately, it was delayed longer than I expected. The capability is deployed to production, but still behind a feature flag that should be enabled for everyone this week. If you can tell me the name of your Azure DevOps organization, I can enable it for you sooner.

@lipkau
Copy link
Member

lipkau commented Nov 26, 2018

@davidstaheli : my org is named AtlassianPS
https://dev.azure.com/AtlassianPS /ConfluencePS

I appreciate your support

@lipkau lipkau added this to the v2.9 milestone Dec 5, 2018
@lipkau lipkau merged commit 8aa72ef into master Dec 5, 2018
@ghost ghost removed the Status:In Review label Dec 5, 2018
@lipkau lipkau deleted the azure-pipelines branch December 5, 2018 22:23
@lipkau lipkau mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants