Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added field parameter #300

Merged
merged 17 commits into from
Jul 8, 2018
Merged

Added field parameter #300

merged 17 commits into from
Jul 8, 2018

Conversation

tuxgoose
Copy link
Contributor

@tuxgoose tuxgoose commented Jul 7, 2018

Description

I modified three current parameters to allow for fields integration(byjql, byissuekey, byfilter)

Motivation and Context

it fixes an open issue
#292

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@tuxgoose tuxgoose requested review from a team as code owners July 7, 2018 20:50
@ghost ghost added the Status:In Review label Jul 7, 2018
@@ -7,6 +7,12 @@ function Get-JiraIssue {
[Alias('Issue')]
[String[]]
$Key,
#added Fields Parameter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description goes in .\docs\en-US\commands\Get-JiraIssue.md

@@ -7,6 +7,12 @@ function Get-JiraIssue {
[Alias('Issue')]
[String[]]
$Key,
#added Fields Parameter
[Parameter(Mandatory=$false)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave empty for non-mandatory parameters

@lipkau lipkau removed the Blocked label Jul 8, 2018
@lipkau lipkau assigned tuxgoose and unassigned lipkau Jul 8, 2018
@lipkau lipkau changed the base branch from master to develop July 8, 2018 14:41
@lipkau lipkau merged commit 925cc9b into AtlassianPS:develop Jul 8, 2018
@ghost ghost removed the Status:In Review label Jul 8, 2018
@lipkau lipkau modified the milestones: v3.0, v2.9 Dec 12, 2018
@lipkau lipkau mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants