Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for cropping to MCWiki standards #20

Open
Tslat opened this issue Jan 14, 2021 · 7 comments
Open

Add option for cropping to MCWiki standards #20

Tslat opened this issue Jan 14, 2021 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@Tslat
Copy link

Tslat commented Jan 14, 2021

Ok this one is a bit specific so I can see why you might not want to do this, but can't hurt to ask right?

So the MCWiki standard for block isometric renders is to have the block rendered as 300x300 px, as seen on any block page:
https://minecraft.gamepedia.com/File:Cobblestone_JE6_BE3.png

Currently the way the scaling works for the mod, it skips from 299px to 302px.
This means that to make wiki-standard isometric renders, you would need to crop the image to 300x300. This works, because the extra 2px is pure buffer on any block render.

Is there a way we can add an option for 300px, or add a way to auto-crop the images to 300px for batch renders? Saves me having to run a photoshop script over every picture to crop it to 300px when rendering in batches

@AterAnimAvis AterAnimAvis added the enhancement New feature or request label Jan 14, 2021
@AterAnimAvis AterAnimAvis added this to the 2.0.0 milestone Jan 14, 2021
@AterAnimAvis
Copy link
Owner

AterAnimAvis commented Jan 14, 2021

Related to #19.

Later today I’ll check the Slider and see if I can make it more precise (Maybe change it to text field?)

Note to self in Unascribed Blockrenderer it was possible to get different sizes via changing the window size, broke this when I disconnected the relation between window size to max render size.

@Tslat
Copy link
Author

Tslat commented Jan 14, 2021

Just need to be careful that the aspect ratio of the render doesn't change with it
302px works well because cropping it to 300px doesn't change anything - the extra 2px are pure whitespace every time

@AterAnimAvis
Copy link
Owner

Allowed arrows / wasd to more finely tune the render size (If the slider was last selected), Added a wiki size button that sets the render size to 300x300.

The ability to define/facilitate post processing steps, i.e. autocropping by 1 pixel on all sides, is something I will add to the 2.0 api spec.

300x300 Slab

300x300 slab

302x302 Slab Cropped to 300x300

302x302 slab cropped

@Tslat
Copy link
Author

Tslat commented Feb 8, 2021

This was added, so I'll close it :)

@Tslat Tslat closed this as completed Feb 8, 2021
@AterAnimAvis
Copy link
Owner

AterAnimAvis commented Feb 8, 2021

Technically not added whilst you can now change the size to 300x300 there’s no auto cropping, anyway glad to be of help.

Reopening as it’s a good example of a post processing step that I want to support with 2.0

@AterAnimAvis AterAnimAvis reopened this Feb 8, 2021
@Tslat
Copy link
Author

Tslat commented Feb 14, 2021

Is there any reason this wasn't added for animated (gif) rendering?
It appears to be only there for static block renders

Thanks for all your hard work btw
If you find a way to do anonymous donations I'll throw something your way

AterAnimAvis added a commit that referenced this issue Feb 14, 2021
---

For some reason I had them disabled.

See #20

Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
@AterAnimAvis
Copy link
Owner

Issue on my end.

It's technically there but not visible due to the fact I copied the logic from the Actual Size button which for some reason was disabled for the Animated Render Screen. I've enabled both for the screen.

Thanks for the offer but there's no need for donations, just happy to be of help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants