-
Notifications
You must be signed in to change notification settings - Fork 28
Check app clip #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check app clip #22
Conversation
|
||
public init(locationManager: CLLocationManager, desiredAccuracy: LocationAccuracy) { | ||
self.locationManager = locationManager | ||
self.locationManager.delegate = locationDelegate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the error "Variable 'self.locationDelegate' used before being initialized" on this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for this, this init was created for tests, I did not notice an error when pushing, corrected :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Now it works just fine. And the solution to add the APPCLIP condition seems to work fine as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I celebrated to early. Uploading to TestFlight now gives the same error as before. I guess the APPCLIP flag does not propagate down to the SPM frameworks :( Not sure how to solve it now. I guess I either have to clone and copy down the code for this framework and the FLAG will be respected, or just skip the framework for my AppClip target and loose all GPS functionality for my AppClip-target :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use cocoapods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given up on Cocoapods a long time ago. SPM only now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll think about how to solve your problem)
@gre4ixin : This change leads to compile-time warnings for anyone using the library, since
Note: Xcode is finicky about whether or not it shows warnings for Swift Packages that are used by an app. Sometimes it does (which is where the above two warnings came from), and sometimes it doesn't. I think this is an Xcode bug, but I'm not sure. |
@tcobbs-bentley use 1.5.6 version) |
No description provided.