Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add laravel 6 #52

Merged
merged 6 commits into from
Sep 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,30 @@ jobs:
MYSQL_ALLOW_EMPTY_PASSWORD: true
<<: *defaults

build-php73-laravel6:
docker:
- image: 'circleci/php:7.2'
environment:
LARAVEL_VERSION: '^6.0'
- image: 'circleci/mysql:5.7'
command: 'mysqld --character-set-server=utf8mb4 --collation-server=utf8mb4_bin --innodb-large-prefix=true --innodb-file-format=Barracuda'
environment:
MYSQL_USER: 'root'
MYSQL_ALLOW_EMPTY_PASSWORD: true
<<: *defaults

build-php72-laravel6:
docker:
- image: 'circleci/php:7.2'
environment:
LARAVEL_VERSION: '^6.0'
- image: 'circleci/mysql:5.7'
command: 'mysqld --character-set-server=utf8mb4 --collation-server=utf8mb4_bin --innodb-large-prefix=true --innodb-file-format=Barracuda'
environment:
MYSQL_USER: 'root'
MYSQL_ALLOW_EMPTY_PASSWORD: true
<<: *defaults

build-php73-laravel58:
docker:
- image: 'circleci/php:7.3'
Expand Down Expand Up @@ -187,7 +211,8 @@ workflows:
version: 2
build_all:
jobs:
- build-php73-laravel58
- build-php73-laravel6
- build-php72-laravel6
- build-php72-laravel58
- build-php72-laravel57
- build-php72-laravel56
44 changes: 26 additions & 18 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
{
"name": "astrotomic/laravel-translatable",
"description": "A Laravel package for multilingual models",
"keywords": ["laravel", "translation", "language", "database"],
"keywords": [
"laravel",
"translation",
"language",
"database"
],
"license": "MIT",
"authors": [
{
Expand All @@ -17,17 +22,25 @@
"role": "Developer"
}
],
"support": {
"issues": "https://github.com/Astrotomic/laravel-translatable/issues"
},
"require": {
"php": ">=7.1.3",
"illuminate/contracts": "5.6.*|5.7.*|5.8.*",
"illuminate/database": "5.6.*|5.7.*|5.8.*",
"illuminate/support": "5.6.*|5.7.*|5.8.*"
"illuminate/contracts": "5.6.* || 5.7.* || 5.8.* || ^6.0",
"illuminate/database": "5.6.* || 5.7.* || 5.8.* || ^6.0",
"illuminate/support": "5.6.* || 5.7.* || 5.8.* || ^6.0"
},
"require-dev": {
"orchestra/testbench": "3.6.*|3.7.*|3.8.*"
"orchestra/testbench": "3.6.* || 3.7.* || 3.8.* || ^4.0",
"orchestra/testbench-core": "3.6.* || 3.7.* || 3.8.* || ^4.0"
},
"config": {
"sort-packages": true
},
"extra": {
"laravel": {
"providers": [
"Astrotomic\\Translatable\\TranslatableServiceProvider"
]
}
},
"autoload": {
"psr-4": {
Expand All @@ -39,17 +52,12 @@
"tests"
]
},
"extra": {
"laravel": {
"providers": [
"Astrotomic\\Translatable\\TranslatableServiceProvider"
]
}
},
"config": {
"sort-packages": true
},
"scripts": {
"csfix": "php-cs-fixer fix --using-cache=no"
},
"support": {
"issues": "https://github.com/Astrotomic/laravel-translatable/issues",
"source": "https://github.com/Astrotomic/laravel-translatable",
"docs": "https://docs.astrotomic.info/laravel-translatable"
}
}
2 changes: 1 addition & 1 deletion tests/LocalesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

use Astrotomic\Translatable\Locales;

class LocalesTest extends TestsBase
final class LocalesTest extends TestsBase
{
public function test_singleton()
{
Expand Down
2 changes: 1 addition & 1 deletion tests/ScopesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use Astrotomic\Translatable\Test\Model\Country;
use Astrotomic\Translatable\Test\Model\Vegetable;

class ScopesTest extends TestsBase
final class ScopesTest extends TestsBase
{
public function test_translated_in_scope_returns_only_translated_records_for_this_locale()
{
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCoreModelExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
use Astrotomic\Translatable\Test\Model\CityTranslation;
use Astrotomic\Translatable\Test\Model\CountryTranslation;

class TestCoreModelExtension extends TestsBase
final class TestCoreModelExtension extends TestsBase
{
// Saving

Expand Down
2 changes: 1 addition & 1 deletion tests/TestsBase.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
use Illuminate\Contracts\Console\Kernel;
use Astrotomic\Translatable\TranslatableServiceProvider;

class TestsBase extends TestCase
abstract class TestsBase extends TestCase
{
protected $queriesCount;
protected static $db2Setup = false;
Expand Down
2 changes: 1 addition & 1 deletion tests/TranslatableTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Astrotomic\Translatable\Test\Model\CountryWithCustomLocaleKey;
use Astrotomic\Translatable\Test\Model\CountryWithCustomTranslationModel;

class TranslatableTest extends TestsBase
final class TranslatableTest extends TestsBase
{
public function test_it_finds_the_default_translation_class()
{
Expand Down
2 changes: 1 addition & 1 deletion tests/ValidationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use Astrotomic\Translatable\Locales;
use Astrotomic\Translatable\Validation\RuleFactory;

class ValidationTest extends TestsBase
final class ValidationTest extends TestsBase
{
public function test_it_does_not_touch_untranslated_keys()
{
Expand Down