Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept $locale in withTranslation scope #413

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

pyrou
Copy link
Contributor

@pyrou pyrou commented Jun 18, 2024

Under some circonstance we want to preview some data in language that are not the current one. But however want to benefit the fallback mechanism.

This PR add ability to specify the locale we want.

Model::query()->withTranslation("de")->get();

As the param is optional, this PR doesn't include breaking changes

Copy link
Member

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Gummibeer Gummibeer merged commit 250f9b3 into Astrotomic:main Jun 24, 2024
12 checks passed
@Gummibeer
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants