Enhance Custom Rules: Introduce translatableExists and translatableUnique for Validating Translatable Attributes #406
Conversation
- Fix PHPDocs, and Code Style
All request changes fixed, and pushed. |
|
Tests seem to fail for Laravel 9 |
… InvokableRule interface instead of the new one introduced in Laravel 10. Future updates will accommodate the removal of Laravel 9 support.
Apologies, @Gummibeer, I hadn't realized the compatibility issue with Laravel 9. The code has been updated to accommodate Laravel 9, but it will require further refinement once Laravel 9 is no longer supported. |
There was a problem hiding this comment.
Thank! 🙏
One little note from my side for future PRs: adding all the doc-tags with type-hints here was the main reason why it took so long for me to review. And I still don't feel 100% confident. I love that you added them to improve autocompletion and IDe support etc. but would have liked it better to add them in a dedicated PR. They aren't really related to the feature but I had to check them to make your feature pass.
Keep your PRs more granular and separated makes it a lot easier to review them and if needed merge one while the other remains open.
Description:
Incorporating unique and existence validation for translatable attributes can be crucial for many projects. The current Laravel validation doesn't inherently support this functionality, prompting the need for custom solutions.
This pull request introduces two custom validation rules,
translatableExists, andtranslatableUnique, tailored specifically for validating translatable attributes. With these additions, developers gain the ability to ensure data integrity and uniqueness within multilingual datasets effortlessly.Changes:
Added
translatableExistsrule to validate the existence of translatable attributes.Introduced
translatableUniquerule for enforcing uniqueness constraints on translatable fields.Purpose:
This enhancement empowers developers to perform comprehensive validation on translatable attributes, enhancing data validation capabilities within multilingual contexts. By providing these custom rules, we aim to streamline development workflows and promote best practices in data validation.
Benefits:
Facilitates validation of translatable attributes for existence and uniqueness.
Enhances data integrity and consistency within multilingual datasets.
Provides developers with versatile tools for enforcing validation rules tailored to translatable fields.
Usage:
Developers can now utilize the
translatableExistsandtranslatableUniquerules in Laravel validation logic to ensure data integrity and uniqueness across multilingual attributes effortlessly.