Merge pull request #52 from Astrotomic/laravel-6

add laravel 6
Astrotomic · Sep 4, 2019 · df7865a · df7865a
2 parents 0003b93 + 0e7a49f
commit df7865a
Show file tree

Hide file tree

Showing 8 changed files with 58 additions and 25 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -75,6 +75,30 @@ jobs:
           MYSQL_ALLOW_EMPTY_PASSWORD: true
     <<: *defaults
 
+  build-php73-laravel6:
+    docker:
+      - image: 'circleci/php:7.2'
+        environment:
+          LARAVEL_VERSION: '^6.0'
+      - image: 'circleci/mysql:5.7'
+        command: 'mysqld --character-set-server=utf8mb4 --collation-server=utf8mb4_bin --innodb-large-prefix=true --innodb-file-format=Barracuda'
+        environment:
+          MYSQL_USER: 'root'
+          MYSQL_ALLOW_EMPTY_PASSWORD: true
+    <<: *defaults
+
+  build-php72-laravel6:
+    docker:
+      - image: 'circleci/php:7.2'
+        environment:
+          LARAVEL_VERSION: '^6.0'
+      - image: 'circleci/mysql:5.7'
+        command: 'mysqld --character-set-server=utf8mb4 --collation-server=utf8mb4_bin --innodb-large-prefix=true --innodb-file-format=Barracuda'
+        environment:
+          MYSQL_USER: 'root'
+          MYSQL_ALLOW_EMPTY_PASSWORD: true
+    <<: *defaults
+
   build-php73-laravel58:
     docker:
       - image: 'circleci/php:7.3'
@@ -187,7 +211,8 @@ workflows:
   version: 2
   build_all:
     jobs:
-      - build-php73-laravel58
+      - build-php73-laravel6
+      - build-php72-laravel6
       - build-php72-laravel58
       - build-php72-laravel57
       - build-php72-laravel56
diff --git a/composer.json b/composer.json
@@ -1,7 +1,12 @@
 {
     "name": "astrotomic/laravel-translatable",
     "description": "A Laravel package for multilingual models",
-    "keywords": ["laravel", "translation", "language", "database"],
+    "keywords": [
+        "laravel",
+        "translation",
+        "language",
+        "database"
+    ],
     "license": "MIT",
     "authors": [
         {
@@ -17,17 +22,25 @@
             "role": "Developer"
         }
     ],
-    "support": {
-        "issues": "https://github.com/Astrotomic/laravel-translatable/issues"
-    },
     "require": {
         "php": ">=7.1.3",
-        "illuminate/contracts": "5.6.*|5.7.*|5.8.*",
-        "illuminate/database": "5.6.*|5.7.*|5.8.*",
-        "illuminate/support": "5.6.*|5.7.*|5.8.*"
+        "illuminate/contracts": "5.6.* || 5.7.* || 5.8.* || ^6.0",
+        "illuminate/database": "5.6.* || 5.7.* || 5.8.* || ^6.0",
+        "illuminate/support": "5.6.* || 5.7.* || 5.8.* || ^6.0"
     },
     "require-dev": {
-        "orchestra/testbench": "3.6.*|3.7.*|3.8.*"
+        "orchestra/testbench": "3.6.* || 3.7.* || 3.8.* || ^4.0",
+        "orchestra/testbench-core": "3.6.* || 3.7.* || 3.8.* || ^4.0"
+    },
+    "config": {
+        "sort-packages": true
+    },
+    "extra": {
+        "laravel": {
+            "providers": [
+                "Astrotomic\\Translatable\\TranslatableServiceProvider"
+            ]
+        }
     },
     "autoload": {
         "psr-4": {
@@ -39,17 +52,12 @@
             "tests"
         ]
     },
-    "extra": {
-        "laravel": {
-            "providers": [
-                "Astrotomic\\Translatable\\TranslatableServiceProvider"
-            ]
-        }
-    },
-    "config": {
-        "sort-packages": true
-    },
     "scripts": {
         "csfix": "php-cs-fixer fix --using-cache=no"
+    },
+    "support": {
+        "issues": "https://github.com/Astrotomic/laravel-translatable/issues",
+        "source": "https://github.com/Astrotomic/laravel-translatable",
+        "docs": "https://docs.astrotomic.info/laravel-translatable"
     }
 }
diff --git a/tests/LocalesTest.php b/tests/LocalesTest.php
@@ -2,7 +2,7 @@
 
 use Astrotomic\Translatable\Locales;
 
-class LocalesTest extends TestsBase
+final class LocalesTest extends TestsBase
 {
     public function test_singleton()
     {

diff --git a/tests/ScopesTest.php b/tests/ScopesTest.php
@@ -3,7 +3,7 @@
 use Astrotomic\Translatable\Test\Model\Country;
 use Astrotomic\Translatable\Test\Model\Vegetable;
 
-class ScopesTest extends TestsBase
+final class ScopesTest extends TestsBase
 {
     public function test_translated_in_scope_returns_only_translated_records_for_this_locale()
     {

diff --git a/tests/TestCoreModelExtension.php b/tests/TestCoreModelExtension.php
@@ -11,7 +11,7 @@
 use Astrotomic\Translatable\Test\Model\CityTranslation;
 use Astrotomic\Translatable\Test\Model\CountryTranslation;
 
-class TestCoreModelExtension extends TestsBase
+final class TestCoreModelExtension extends TestsBase
 {
     // Saving
 

diff --git a/tests/TestsBase.php b/tests/TestsBase.php
@@ -4,7 +4,7 @@
 use Illuminate\Contracts\Console\Kernel;
 use Astrotomic\Translatable\TranslatableServiceProvider;
 
-class TestsBase extends TestCase
+abstract class TestsBase extends TestCase
 {
     protected $queriesCount;
     protected static $db2Setup = false;

diff --git a/tests/TranslatableTest.php b/tests/TranslatableTest.php
@@ -9,7 +9,7 @@
 use Astrotomic\Translatable\Test\Model\CountryWithCustomLocaleKey;
 use Astrotomic\Translatable\Test\Model\CountryWithCustomTranslationModel;
 
-class TranslatableTest extends TestsBase
+final class TranslatableTest extends TestsBase
 {
     public function test_it_finds_the_default_translation_class()
     {

diff --git a/tests/ValidationTest.php b/tests/ValidationTest.php
@@ -3,7 +3,7 @@
 use Astrotomic\Translatable\Locales;
 use Astrotomic\Translatable\Validation\RuleFactory;
 
-class ValidationTest extends TestsBase
+final class ValidationTest extends TestsBase
 {
     public function test_it_does_not_touch_untranslated_keys()
     {