make exception more precise

Astrotomic · Jan 28, 2020 · 1ef559c · 1ef559c
1 parent 5203dbf
commit 1ef559c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Translatable/Translatable.php b/src/Translatable/Translatable.php
@@ -242,7 +242,7 @@ public function getTranslationOrNew(?string $locale = null): Model
     public function getTranslationOrFail(string $locale): Model
     {
         if (($translation = $this->getTranslation($locale, false)) === null) {
-            throw new ModelNotFoundException();
+            throw (new ModelNotFoundException)->setModel($this->getTranslationModelName(), $locale);
         }
 
         return $translation;

diff --git a/tests/TranslatableTest.php b/tests/TranslatableTest.php
@@ -418,12 +418,14 @@ public function it_has_methods_that_return_always_a_translation(): void
     /** @test */
     public function it_throws_an_exception_if_translation_does_not_exist(): void
     {
+        $this->expectException(ModelNotFoundException::class);
+        $this->expectExceptionMessage(sprintf('No query results for model [%s] %s', VegetableTranslation::class, 'xyz'));
+
         $vegetable = Vegetable::create([
             'en' => ['name' => 'Peas'],
         ]);
         static::assertEquals('en', $vegetable->translateOrFail('en')->locale);
 
-        $this->expectException(ModelNotFoundException::class);
         $vegetable->translateOrFail('xyz');
     }