Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treesitter): update treesitter to use new highlight naming scheme #105

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

A-Lamia
Copy link
Contributor

@A-Lamia A-Lamia commented Jan 20, 2024

📑 Description

Updates the highlight groups to reflect breaking changes in nvim-treesitter/nvim-treesitter@1ae9b0e.
Also did a general cleanup of code structure and made sure to link groups for most the legacy highlight that should be removed at some point.

@A-Lamia A-Lamia changed the title fix!: update treesitter to use new highlight naming scheme fix(treesitter)!: update treesitter to use new highlight naming scheme Jan 20, 2024
@mehalter mehalter assigned A-Lamia and unassigned mehalter Jan 20, 2024
@A-Lamia
Copy link
Contributor Author

A-Lamia commented Jan 20, 2024

Don't merge this yet.

@A-Lamia
Copy link
Contributor Author

A-Lamia commented Jan 20, 2024

Ok good to go.

@mehalter mehalter self-requested a review January 20, 2024 19:28
@mehalter
Copy link
Member

Is there a way to make this non breaking? Even if it means maintaining some old highlights for a bit? I'm away from a computer so I haven't looked at the code

@A-Lamia A-Lamia changed the title fix(treesitter)!: update treesitter to use new highlight naming scheme fix(treesitter): update treesitter to use new highlight naming scheme Jan 21, 2024
@A-Lamia
Copy link
Contributor Author

A-Lamia commented Jan 21, 2024

Is there a way to make this non breaking? Even if it means maintaining some old highlights for a bit? I'm away from a computer so I haven't looked at the code

It was always none breaking i just made a mistake haha.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks!

@mehalter mehalter merged commit b37ac47 into main Jan 21, 2024
11 checks passed
@mehalter mehalter deleted the update_treesitter branch January 21, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants