Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimise footer for mobile #7

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

t1gu1
Copy link
Contributor

@t1gu1 t1gu1 commented Oct 13, 2023

📑 Description

Footer on mobile needed a bit of love.
It didn't respect the padding p-8 on each side before.
Also the row of icon didn't wrap when too small.

It doesn't change the desktop visual.
Only mobile

ℹ Additional Information

Before

image

After

image

Desktop dont change

image

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for sage-valkyrie-89a9e7 ready!

Name Link
🔨 Latest commit 7b944ec
🔍 Latest deploy log https://app.netlify.com/sites/sage-valkyrie-89a9e7/deploys/6528e4674e7db400080ee4a3
😎 Deploy Preview https://deploy-preview-7--sage-valkyrie-89a9e7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 32 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 90 (🟢 up 10 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@t1gu1 t1gu1 force-pushed the fix/add-padding-to-mobile-footer branch from 0549d5f to 7b944ec Compare October 13, 2023 06:32
@t1gu1 t1gu1 changed the title Optimise footer for mobile fix: optimise footer for mobile Oct 13, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is perfect!

@mehalter mehalter added the hacktoberfest-accepted Accepted for Hacktober Fest label Oct 13, 2023
@mehalter mehalter merged commit e97417f into AstroNvim:main Oct 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktober Fest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants