Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pack): Fix path_regex regular expression #1284

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

lucazz
Copy link
Contributor

@lucazz lucazz commented Dec 8, 2024

📑 Description

There was a typo on the regular expression that evaluates well-known Ansible paths.
Closes #1283

ℹ Additional Information

With the current version of pack in place, we have the following error message:
Screenshot 2024-12-08 at 1 31 15 PM

Error rendering component icon: .../astrocommunity/lua/astrocommunity/pack/ansible/init.lua:7: couldn't parse regex: Vim:E55: Unmatched )

With this fix, these errors are gone:
Screenshot 2024-12-08 at 1 29 45 PM

Copy link

github-actions bot commented Dec 8, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft merged commit bc828fc into AstroNvim:main Dec 13, 2024
16 checks passed
@lucazz lucazz deleted the fix-ansible-pack branch December 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants