Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpectralType class #42

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Add SpectralType class #42

merged 11 commits into from
Sep 12, 2024

Conversation

teutoburg
Copy link
Collaborator

@teutoburg teutoburg commented Sep 10, 2024

Who needed that now??

Weeeell, technically one of our students would have benefited from this a little while back. More to the point, this will come in handy for scopesim-targets (maybe even for ScopeSim_Templates) and Pyckles and maybe also SpeXtra. Also, it took just this afternoon from initial idea to implementation including all 77 test cases, so why not 🤷‍♂️

@teutoburg teutoburg added the enhancement New feature or request label Sep 10, 2024
@teutoburg teutoburg self-assigned this Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (ff7168e) to head (c165603).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   99.16%   99.26%   +0.09%     
==========================================
  Files           5        6       +1     
  Lines         361      409      +48     
==========================================
+ Hits          358      406      +48     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg marked this pull request as ready for review September 10, 2024 15:26
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O be a fine guy, kindly merge

astar_utils/spectral_types.py Outdated Show resolved Hide resolved
@teutoburg teutoburg merged commit a242537 into main Sep 12, 2024
18 checks passed
@teutoburg teutoburg deleted the fh/spectypes branch September 12, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants