Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skycalc_cli from dependencies #481

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Remove skycalc_cli from dependencies #481

merged 1 commit into from
Oct 21, 2024

Conversation

teutoburg
Copy link
Contributor

I don't think this was used anywhere, that's what we have skycalc_ipy for!

Removing this also finally gets rid of setuptools as an indirect dependency.

I don't think this was used anywhere, that's what we have skycalc_ipy for!

Removing this also finally gets rid of setuptools as an indirect dependency.
@teutoburg teutoburg added the dependencies Related to or updating any dependencies label Oct 21, 2024
@teutoburg teutoburg self-assigned this Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.58%. Comparing base (6ce5e06) to head (f802342).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   76.58%   76.58%           
=======================================
  Files          66       66           
  Lines        8094     8094           
=======================================
  Hits         6199     6199           
  Misses       1895     1895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg marked this pull request as ready for review October 21, 2024 13:02
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, but only if you ensure that "readthedocs doesn't include the tests module", or that it is not a problem if that happens anyway.

I just copied that line from 74f98e7d ; I don't know what it actually means.

@teutoburg
Copy link
Contributor Author

Fine with me, but only if you ensure that "readthedocs doesn't include the tests module", or that it is not a problem if that happens anyway.

The RTD build for this branch looks just fine. Except ofc for the three example notebooks, but that's very much a separate issue that we're already aware of. In the reference API section, which includes all the modules, there is no "test(s)" anywhere to be seen. So I guess we're good on that.

I just copied that line from 74f98e7d ; I don't know what it actually means.

I always wondered about this comment. Maybe I'll ask @astronomyk if he remembers 🙃

But this might actually have been outdated after moving to poetry, or maybe even already after moving to pyprject.toml...

@teutoburg teutoburg merged commit c33f0fe into main Oct 21, 2024
22 checks passed
@teutoburg teutoburg deleted the fh/nomoreskycalccli branch October 21, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to or updating any dependencies
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants