Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT : my atmospheric shift and transmission code for MOSAIC #203

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JamianStephan
Copy link
Collaborator

First contribution of MOSAIC atmopsheric shift and transmission code to SCOPESIM.

Contains class of simulation and corresponding utility functions added to the effects file.

Purpose is to include the effects of atmospheric dispersion into the transmission traces of SCOPESIM simulations, where off-set PSFs cause differential losses through observing bands. Takes in parameters such as telescope guiding, aperture centre wavelength, observation details (hour angles, declination etc.) to establish the effect.

@astronomyk astronomyk changed the title First commit of my atmospheric shift and transmission code for MOSAIC DRAFT : my atmospheric shift and transmission code for MOSAIC Apr 26, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.13 ⚠️

Comparison is base (b75af4b) 75.13% compared to head (330322a) 74.01%.

❗ Current head 330322a differs from pull request most recent head 1180925. Consider uploading reports for the commit 1180925 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #203      +/-   ##
==============================================
- Coverage       75.13%   74.01%   -1.13%     
==============================================
  Files             147      149       +2     
  Lines           15181    15411     +230     
==============================================
  Hits            11406    11406              
- Misses           3775     4005     +230     
Impacted Files Coverage Δ
scopesim/effects/atmo_disp_shifts_trans.py 0.00% <0.00%> (ø)
scopesim/effects/atmo_disp_shifts_trans_utils.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

JamianStephan and others added 5 commits May 2, 2023 14:43
Cleaned up the code, added more comments for clarity, fixed HR NIR mode
1) Added a class variable containing pd table of fibre dimensions,
columns of fibre_id,dx,dy
2) Changed run function's transmission array to a dictionary with keys of fibre_id
Implemented code to generate a hexagonal aperture array for an arbitrary number of rings
HR_VIS now is working as a 3-layer hexagon array can be made
Hexagonal aperture arrays were odd-sized with a central pixel
This meant hexagons would leave a gap or overlap due to symmetry
Fixed so that the arrays for the aperture and PSF arrays are now even-sized
@hugobuddel hugobuddel marked this pull request as draft June 13, 2023 11:03
Base automatically changed from dev_master to main April 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants