Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use 'dispatch' instead of dApp staking precompiled contract for dApp staking via EVM wallets #930

Merged
merged 2 commits into from
Sep 18, 2023
Merged

feat: use 'dispatch' instead of dApp staking precompiled contract for dApp staking via EVM wallets #930

merged 2 commits into from
Sep 18, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Sep 15, 2023 •
edited
Loading

Pull Request Summary

  • feat: use dispatch instead of dApp staking precompiled contract for dApp staking via EVM wallets
    • batchAll precompiled contract will be removed soon
    • this fixes staking 'WASM' contract issue
  • fix: open 'My Rewards' tab after sending withdrawal transaction on dApp staking page

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit b2acddc):

https://astar-apps--pr930-feat-update-evm-dapp-gbhtgzjf.web.app

(expires Sat, 23 Sep 2023 07:30:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto changed the title feat: use 'dispatch' instead of precompiled dApp staking contract feat: use 'dispatch' instead of dApp staking precompiled contract for dApp staking via EVM wallets Sep 15, 2023
@impelcrypto impelcrypto marked this pull request as ready for review September 15, 2023 16:21
gluneau
gluneau approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Further tests were trouble free.

Kahonnohak
Kahonnohak approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets find solution for indexing later

@impelcrypto impelcrypto merged commit d7aa48f into main Sep 18, 2023
@impelcrypto impelcrypto deleted the feat/update-evm-dappstaking branch September 18, 2023 13:46
bobo-k2 pushed a commit that referenced this pull request Oct 3, 2023
@impelcrypto @bobo-k2
feat: use 'dispatch' instead of dApp staking precompiled contract for…
937ebb8 
… dApp staking via EVM wallets (#930)

* feat: use 'dispatch' instead of precompiled dApp staking contract

* fix: use mapped SS58 account to fetch the staking transactions history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@gluneau gluneau gluneau approved these changes

@bobo-k2 bobo-k2 Awaiting requested review from bobo-k2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@impelcrypto @gluneau @Kahonnohak